-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Single settings file generation #3378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
force-pushed
the
feat/single-settings-file
branch
from
October 11, 2024 01:39
c13c170
to
da90bc5
Compare
mkundu1
commented
Oct 11, 2024
mkundu1
commented
Oct 11, 2024
mkundu1
commented
Oct 11, 2024
mkundu1
requested review from
seanpearsonuk,
prmukherj and
hpohekar
as code owners
October 11, 2024 18:38
mkundu1
force-pushed
the
feat/single-settings-file
branch
from
October 12, 2024 18:13
d3cb5b7
to
90d4faa
Compare
mkundu1
force-pushed
the
feat/single-settings-file
branch
from
October 12, 2024 18:15
90d4faa
to
6881032
Compare
seanpearsonuk
approved these changes
Oct 14, 2024
hpohekar
approved these changes
Oct 15, 2024
Looks good. Thank you. |
prmukherj
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new settingsgen.py has been added to write the settings API classes in a single file. The old one is still available behind
PYFLUENT_USE_OLD_SETTINGSGEN
environment variable to triage any issue due to the new mechanism. The filesize of the generated file together with the stub file is about 5 MB in the new mechanism:This has reduced the .whl size from 36 MB (0.26.1 build) to 5.5 MB.
Testing: