Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Single settings file generation #3378

Merged
merged 13 commits into from
Oct 15, 2024
Merged

feat: Single settings file generation #3378

merged 13 commits into from
Oct 15, 2024

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Oct 9, 2024

A new settingsgen.py has been added to write the settings API classes in a single file. The old one is still available behind PYFLUENT_USE_OLD_SETTINGSGEN environment variable to triage any issue due to the new mechanism. The filesize of the generated file together with the stub file is about 5 MB in the new mechanism:

D:\ANSYSDev\PyFluentDev\pyfluent>ls -l src\ansys\fluent\core\generated\solver      
total 9692
-rw-r--r-- 1 mkundu Domain Users 2837400 Oct 11 14:07 settings_251.py
-rw-r--r-- 1 mkundu Domain Users 1904201 Oct 11 14:07 settings_251.pyi

This has reduced the .whl size from 36 MB (0.26.1 build) to 5.5 MB.

Testing:

  1. Ran Fluent regressions
  2. Compared api_tree with the old mechanism.

@mkundu1 mkundu1 force-pushed the feat/single-settings-file branch from c13c170 to da90bc5 Compare October 11, 2024 01:39
pyproject.toml Show resolved Hide resolved
@mkundu1 mkundu1 marked this pull request as ready for review October 11, 2024 18:38
@mkundu1 mkundu1 linked an issue Oct 11, 2024 that may be closed by this pull request
@mkundu1 mkundu1 force-pushed the feat/single-settings-file branch from d3cb5b7 to 90d4faa Compare October 12, 2024 18:13
@mkundu1 mkundu1 force-pushed the feat/single-settings-file branch from 90d4faa to 6881032 Compare October 12, 2024 18:15
@hpohekar
Copy link
Collaborator

Looks good. Thank you.

@mkundu1 mkundu1 merged commit 8c71972 into main Oct 15, 2024
26 of 27 checks passed
@mkundu1 mkundu1 deleted the feat/single-settings-file branch October 15, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research single file generation for settings API
4 participants