Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle names in parent path for direct settings objects #3435

Merged
merged 2 commits into from
Nov 12, 2024
Merged

feat: Handle names in parent path for direct settings objects #3435

merged 2 commits into from
Nov 12, 2024

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Oct 29, 2024 •
edited
Loading

Example of multiple named object parents:

    assert (
        DesignPoint(
            settings_source=solver,
            parametric_studies="mixing_elbow-Solve",
            name="Base DP",
        )
        == solver.parametric_studies["mixing_elbow-Solve"].design_points["Base DP"]

@mkundu1 mkundu1 linked an issue Oct 29, 2024 that may be closed by this pull request
Handle multiple names in path in direct settings class #3429
Closed
@mkundu1 mkundu1 changed the title feat: update base feat: Handle names in parent path for direct settings objects Oct 29, 2024
@mkundu1 mkundu1 force-pushed the feat/multiple-named-objects branch from 28b26de to 457f2c9 Compare October 29, 2024 12:45
@mkundu1 mkundu1 marked this pull request as ready for review October 29, 2024 12:45
@mkundu1 mkundu1 merged commit 96d9b57 into main Nov 12, 2024
26 checks passed
@mkundu1 mkundu1 deleted the feat/multiple-named-objects branch November 12, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prmukherj prmukherj prmukherj approved these changes

@hpohekar hpohekar hpohekar approved these changes

@seanpearsonuk seanpearsonuk Awaiting requested review from seanpearsonuk seanpearsonuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle multiple names in path in direct settings class
3 participants
@mkundu1 @hpohekar @prmukherj