-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search module improvements #3497
Conversation
Co-authored-by: Sean Pearson <[email protected]>
@hpohekar We don't support search_root in the new search function. Feel free to clean up the function |
@hpohekar we'll check if any change in required for PyConsole after merging this PR |
@hpohekar Can you please add this test?
|
We are supporting all 3 tests. Done. Thank you. |
@seanpearsonuk @mkundu1 We have implemented all suggestions and added more tests. Let me know if you want to add any specific test cases. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The present changes look good to me, thanks. There is one issue related to the presentationof the results, will file a separate defect.
Sure. Please go ahead. Thank you. |
closes #3496, #3498, #3499
Improve synset handling
Remove duplicate data and dependency on
api_tree_version.pickle
fileapi_tree_<version>.pickle
file.Refactor flobject.py for search function
_search
.test_search.py
and removed tests related to legacy search function.settings_extrenal.py
Reorder search function
Add more tests