Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace scheme call in get_vector_fields #3514

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Nov 25, 2024

closes #3512

Replaced scheme call in get_vector_fields()

@hpohekar hpohekar marked this pull request as draft November 25, 2024 13:02
@prmukherj
Copy link
Collaborator

@hpohekar, I think we can address all the scheme calls together in a PR? We can update the proto files as required for this. What do you think?

@seanpearsonuk
Copy link
Collaborator

@hpohekar, I think we can address all the scheme calls together in a PR? We can update the proto files as required for this. What do you think?

@prmukherj code change so far looks potentially OK (as far as I can tell). Isn't this approach OK, gradually removing the Scheme dependencies?

@prmukherj
Copy link
Collaborator

@hpohekar, I think we can address all the scheme calls together in a PR? We can update the proto files as required for this. What do you think?

@prmukherj code change so far looks potentially OK (as far as I can tell). Isn't this approach OK, gradually removing the Scheme dependencies?

Yes @seanpearsonuk, should be fine. Just wanted to take a look into all the calls once and decide, that's all.

@hpohekar hpohekar marked this pull request as ready for review November 26, 2024 09:23
@hpohekar hpohekar changed the title feat: Replace scheme calls feat: Replace scheme call in get_vector_fields Nov 26, 2024
@hpohekar hpohekar enabled auto-merge (squash) November 27, 2024 03:25
@hpohekar hpohekar merged commit bf4f01d into main Nov 27, 2024
29 checks passed
@hpohekar hpohekar deleted the feat/replace_scheme_eval_calls branch November 27, 2024 07:56
@prmukherj
Copy link
Collaborator

Tested visualization with this update and seems to run correctly. So no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace some scheme_eval service calls
4 participants