-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace scheme call in get_vector_fields #3514
Conversation
@hpohekar, I think we can address all the scheme calls together in a PR? We can update the proto files as required for this. What do you think? |
@prmukherj code change so far looks potentially OK (as far as I can tell). Isn't this approach OK, gradually removing the Scheme dependencies? |
Yes @seanpearsonuk, should be fine. Just wanted to take a look into all the calls once and decide, that's all. |
Tested visualization with this update and seems to run correctly. So no effect. |
closes #3512
Replaced scheme call in
get_vector_fields()