Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Data model cache refactoring #3527

Merged
merged 1 commit into from
Nov 27, 2024
Merged

refactor: Data model cache refactoring #3527

merged 1 commit into from
Nov 27, 2024

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Nov 27, 2024 •
edited
Loading

closes #1772

  1. Updated _update_cache_from_variant_state & update_cache
  2. Renamed updaterFn -> updater_fn

@hpohekar hpohekar marked this pull request as ready for review November 27, 2024 09:37
@hpohekar hpohekar merged commit 8396888 into main Nov 27, 2024
29 checks passed
@hpohekar hpohekar deleted the fix/data_model_cache_refactoring branch November 27, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prmukherj prmukherj prmukherj approved these changes

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@mkundu1 mkundu1 Awaiting requested review from mkundu1 mkundu1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data model cache small refactor suggestions
3 participants
@hpohekar @seanpearsonuk @prmukherj