Move docker import so it works without docker installed #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpearsonuk
approved these changes
Jun 17, 2022
| @@ -98,6 +97,7 @@ | |||
|
|
|||
| def _copy_tui_help_xml_file(): | |||
| if os.getenv("PYFLUENT_LAUNCH_CONTAINER") == "1": | |||
| import docker | |||
There was a problem hiding this comment.
maybe the style check wants an empty line after the import
There was a problem hiding this comment.
Hmph forgot to install pre-commit in my venv... yup.
There was a problem hiding this comment.
yeah that's a common annoyance
dnwillia-work
force-pushed
the
fix/delaydocker
branch
from
c431d5d to
2d31956
Compare
mkundu1
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker import will not work if docker package is not installed, We should not require this for local dev work.