Update readme and other changes #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
commented
Jun 24, 2022
README.rst
Outdated
| :alt: PyAnsys | ||
|
|
||
| .. |pypi| image:: https://img.shields.io/pypi/v/pyfluent.svg?logo=python&logoColor=white | ||
| :target: https://pypi.org/project/pyfluent |
There was a problem hiding this comment.
There is an existing pypi package here. We probably need to use a different link, e.g. https://pypi.org/project/pyfluent-core
mkundu1
commented
Jun 24, 2022
| @@ -28,7 +27,7 @@ | |||
| "numpy>=1.21.5", | |||
| "protobuf==3.20.1", | |||
| "appdirs>=1.4.0", | |||
| "pandas>=1.4.1" if sys.version_info.minor > 7 else "pandas==1.3.5", | |||
| "pandas>=1.1.5", | |||
There was a problem hiding this comment.
This is the maximum supported version for python 3.7.0 (the minimum python version we support).
seanpearsonuk
approved these changes
Jun 24, 2022
mkundu1
commented
Jun 24, 2022
| in the *PyAnsys Developer's Guide*. Ensure that you are thoroughly familiar with | ||
| it and all `Guidelines and Best Practices | ||
| <https://dev.docs.pyansys.com/guidelines/index.html>`_ before attempting to | ||
| it and `Coding Style |
There was a problem hiding this comment.
There doesn't seem to be a Guidelines and Best Practices section at present. Coding Style is the closest I could find.
There was a problem hiding this comment.
Yeah, they moved all the guidelines to the "How-To" instead.
dnwillia-work
approved these changes
Jun 24, 2022
dnwillia-work
approved these changes
Jun 24, 2022
* Adding some doc examples 01 * Adding journal title Co-authored-by: Anurag Kulshrestha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.