Fix/refactoring flobject.py #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpohekar
requested review from
dnwillia-work,
h-krishnan,
seanpearsonuk,
mkundu1 and
ajain-work
h-krishnan
approved these changes
Jul 21, 2022
hpohekar
force-pushed
the
fix/refactoring_command_query_get_cls_flobject
branch
from
b83c02e to
ccb5521
Compare
mkundu1
approved these changes
Jul 21, 2022
seanpearsonuk
approved these changes
Jul 21, 2022
|
@hpohekar Please can you create a Fluent PR with the same changes since flobject.py also exists in Fluent for the PyConsole feature. |
hpohekar
force-pushed
the
fix/refactoring_command_query_get_cls_flobject
branch
from
ccb5521 to
8dc630e
Compare
|
Hello @seanpearsonuk I have created a Fluent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed code duplications in command, query and get_cls.