Use static info for tuigen #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
force-pushed
the
feat/tui-static-info
branch
2 times, most recently
from
d979da5 to
4fe445a
Compare
mkundu1
commented
Jul 21, 2022
mkundu1
commented
Jul 21, 2022
mkundu1
force-pushed
the
feat/tui-static-info
branch
3 times, most recently
from
f8d46ad to
a25f74b
Compare
mkundu1
commented
Jul 21, 2022
mkundu1
commented
Jul 21, 2022
mkundu1
commented
Jul 21, 2022
dnwillia-work
approved these changes
Jul 21, 2022
mkundu1
force-pushed
the
feat/tui-static-info
branch
from
a25f74b to
60c99d9
Compare
seanpearsonuk
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 23.1,
GetStaticInforpc will be used for tuigen. I've also reduced the codegen frequency in CI. For 22.2, we shall always restore the generated code from cache (changes are not in the current PR).