Remove 23.1 doc builds from PR CI/CD pipeline #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwillia-work
force-pushed
the
docs/buildfix
branch
from
4240e18 to
939823b
Compare
dnwillia-work
force-pushed
the
docs/buildfix
branch
4 times, most recently
from
0ab87a8 to
998783f
Compare
dnwillia-work
changed the title
dnwillia-work
changed the title
dnwillia-work
force-pushed
the
docs/buildfix
branch
from
998783f to
4bf7c76
Compare
dnwillia-work
force-pushed
the
docs/buildfix
branch
from
4bf7c76 to
5fa4044
Compare
mkundu1
approved these changes
Jul 29, 2022
egravenh
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elijah reported a couple doc build failures this afternoon:
https://github.com/pyansys/pyfluent/pull/680/checks
https://github.com/pyansys/pyfluent/pull/664/checks
The problem seemed to be that the 'ansys.fluent.core.settings' package was not properly installed into the Python environment at the build step 'Install again after codegen'. At that point we've already installed the package during the previous step labelled 'Install PyFluent', but without the generated code, and pip does not seem to overwrite it with the updated wheel. Setting up
make installto force re-installation does the trick.I thought what we had agreed about the 23.1 doc builds was that we should just be building it once a day in the nightly doc pipeline, so added it there and removed it from the PR pipeline. The development documentation at
dev.fluentdoc.pyansys.comis updated in that pipeline using 22.2.The PR pipeline is still running the tests 2x with both 22.2 and 23.1, which doubles the testing time:
It might be prudent to move the 23.1 PR testing to an additional nightly build pipeline as well.