Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/enable command args for datamodel se #735

Merged
merged 12 commits into from
Aug 22, 2022

Conversation

prmukherj
Copy link
Collaborator

No description provided.

@seanpearsonuk
Copy link
Collaborator

@prmukherj I have restarted the CI. tuigen was failing which shouldn't be triggered by these changes.

@mkundu1 mkundu1 self-requested a review August 19, 2022 07:15
@mkundu1 mkundu1 marked this pull request as ready for review August 19, 2022 07:15
@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented Aug 19, 2022

@mkundu1 @prmukherj

There seem to be two classes of errors in the 23R1 failing tests:

  • mysteriously missing TUI menus. Some menus are missing in these tests, but I see them locally in PyFluent and in the Fluent TUI. Those affect meshing and solver

  • settings API updates between 22R2 and 23R1 that are not reflected in these tests:
    (a) difference between {'constant': 0, 'option': 'constant or expression'} and later {'option': 'value', 'value': 0}
    (b) difference between materials.copy_database_material_by_name(...) and later materials.database.copy_by_name(...)
    for each of these I propose a test util wrapper function:
    (a) compare_constants and (b) copy_material

Are we able to check the backend version from within the test?

* fix tests

* fix tests

* fix tests
@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented Aug 19, 2022

@mkundu1 @prmukherj

There seem to be two classes of errors in the 23R1 failing tests:

  • mysteriously missing TUI menus. Some menus are missing in these tests, but I see them locally in PyFluent and in the Fluent TUI. Those affect meshing and solver
  • settings API updates between 22R2 and 23R1 that are not reflected in these tests:
    (a) difference between {'constant': 0, 'option': 'constant or expression'} and later {'option': 'value', 'value': 0}
    (b) difference between materials.copy_database_material_by_name(...) and later materials.database.copy_by_name(...)
    for each of these I propose a test util wrapper function:
    (a) compare_constants and (b) copy_material

Are we able to check the backend version from within the test?

I have merged some test changes so that all settings API issues are resolved. We are now down to just those TUI API issues. TUI API Issues are not reproducible locally here!
@mkundu1 @prmukherj

@prmukherj prmukherj linked an issue Aug 22, 2022 that may be closed by this pull request
@prmukherj prmukherj merged commit b19fe2e into main Aug 22, 2022
@prmukherj prmukherj deleted the feat/enable_command_args_for_datamodel_se branch August 22, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable create / delete code command-args for datamodel_se
3 participants