Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segregate generated files into Fluent-version-specific directories #771

Merged
merged 12 commits into from
Aug 28, 2022

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Aug 24, 2022

The string "_222" or "_231" has been appended to the generated API file/directory names. API modules are loaded based on version of the connected Fluent session.

@mkundu1 mkundu1 force-pushed the feat/codegen branch 2 times, most recently from 376679d to b3c1fd4 Compare August 25, 2022 14:19
@mkundu1 mkundu1 marked this pull request as ready for review August 25, 2022 18:43
Copy link
Collaborator

@seanpearsonuk seanpearsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks

@mkundu1 mkundu1 closed this Aug 28, 2022
@mkundu1 mkundu1 reopened this Aug 28, 2022
@mkundu1 mkundu1 merged commit 775fa86 into main Aug 28, 2022
@mkundu1 mkundu1 deleted the feat/codegen branch August 28, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to segregate generated files into Fluent-version-specific directories
4 participants