-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segregate generated files into Fluent-version-specific directories #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
force-pushed
the
feat/codegen
branch
2 times, most recently
from
August 25, 2022 14:19
376679d
to
b3c1fd4
Compare
mkundu1
requested review from
seanpearsonuk,
prmukherj,
ajain-work,
dnwillia-work and
hpohekar
August 25, 2022 18:47
mkundu1
commented
Aug 25, 2022
prmukherj
approved these changes
Aug 26, 2022
hpohekar
approved these changes
Aug 26, 2022
mkundu1
commented
Aug 26, 2022
seanpearsonuk
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string "_222" or "_231" has been appended to the generated API file/directory names. API modules are loaded based on version of the connected Fluent session.