Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly CI to compare flobject #919

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Add nightly CI to compare flobject #919

merged 1 commit into from
Sep 22, 2022

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Sep 22, 2022

Sample output (from a test CI run):

--- fluent_flobject.py	2022-09-13 17:00:29.000000000 +0000
+++ src/ansys/fluent/core/solver/flobject.py	2022-09-22 07:50:55.709520981 +0000
@@ -[14](https://github.com/pyansys/pyfluent/actions/runs/3103707183/jobs/5027335865#step:6:15)5,7 +145,7 @@
         """Get the requested attribute for the object."""
         attrs = self.get_attrs([attr])
         attrs = attrs.get("attrs", attrs)
Traceback (most recent call last):
-        if attr != "active?" and attrs.get("active?", True) is False:
+        if attr != "active?" and attrs and attrs.get("active?", True) is False:
             raise RuntimeError("Object is not active")
         return attrs[attr] if attrs else None
 
  File "/home/runner/work/pyfluent/pyfluent/.ci/compare_flobject.py", line 31, in <module>
@@ -864,7 +864,7 @@
    compare_flobject()
                     dct["__doc__"] = f"'{pname.strip('_')}' child."
 
         include_child_named_objects = info.get("include_child_named_objects", False)
-        user_creatable = info.get("user_creatable", False)
+        user_creatable = info.get("user_creatable", True)
 
         bases = (base,)
         if include_child_named_objects:

  File "/home/runner/work/pyfluent/pyfluent/.ci/compare_flobject.py", line [27](https://github.com/pyansys/pyfluent/actions/runs/3103707183/jobs/5027335865#step:6:28), in compare_flobject
    raise RuntimeError("flobject.py is different in Fluent and PyFLuent.")
RuntimeError: flobject.py is different in Fluent and PyFLuent.
make: *** [Makefile:58: compare-flobject] Error 1
Error: Process completed with exit code 2.

@mkundu1 mkundu1 force-pushed the maint/compare-flobject branch from d1ea4fb to 698f5f3 Compare September 22, 2022 06:04
@mkundu1 mkundu1 force-pushed the maint/compare-flobject branch from 193c94b to 5591c9b Compare September 22, 2022 07:57
@mkundu1 mkundu1 changed the title Maint/compare flobject Add nightly CI to compare flobject Sep 22, 2022
@mkundu1 mkundu1 marked this pull request as ready for review September 22, 2022 08:00
@mkundu1 mkundu1 merged commit 633b266 into main Sep 22, 2022
@mkundu1 mkundu1 deleted the maint/compare-flobject branch September 22, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants