Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for -g and -gu for windows platform #995

Merged
merged 9 commits into from
Oct 19, 2022

Conversation

hpohekar
Copy link
Collaborator

image

image

@prmukherj prmukherj self-requested a review October 14, 2022 14:08
@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented Oct 18, 2022

@hpohekar Unfortunately, e.g., s=pf.launch_fluent(mode="solver", show_gui=True, additional_arguments="-g") is still allowed and it starts in -g mode. The check needs to be more comprehensive.

Copy link
Collaborator

@seanpearsonuk seanpearsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per previous comment. Perhaps we could also add a test for the expected behaviour.

@hpohekar
Copy link
Collaborator Author

@hpohekar Unfortunately, e.g., s=pf.launch_fluent(mode="solver", show_gui=True, additional_arguments="-g") is still allowed and it starts in -g mode. The check needs to be more comprehensive.

Done. Thank you.

@hpohekar
Copy link
Collaborator Author

As per previous comment. Perhaps we could also add a test for the expected behaviour.

Done. Thank you.

@prmukherj
Copy link
Collaborator

@hpohekar, please look at the current implementation.
@seanpearsonuk, the tests should run locally without any issues, however though we have a case that should launch fluent in '-g' mode in linux as well. Let's see if the tests behave as we expect them to :).

@hpohekar
Copy link
Collaborator Author

@hpohekar, please look at the current implementation. @seanpearsonuk, the tests should run locally without any issues, however though we have a case that should launch fluent in '-g' mode in linux as well. Let's see if the tests behave as we expect them to :).

Yes, looks good. Thank you.

@prmukherj prmukherj merged commit 23c9155 into main Oct 19, 2022
@prmukherj prmukherj deleted the fix/exception_for_g_and_gu_mode_on_windows branch October 19, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyFluent: Fluent requires users input to proceed when started in the -g mode (or "-gu -driver null" mode).
4 participants