Skip to content

Commit

Permalink
feat: implemented review comments and updated affected actions
Browse files Browse the repository at this point in the history
  • Loading branch information
moe-ad committed Nov 28, 2024
1 parent 12da443 commit d7e7d6a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 18 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/ci_cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,6 @@ jobs:
path: doc/_build/html
retention-days: 7

- name: Upload PDF Documentation
uses: actions/upload-artifact@v4
with:
name: documentation-pdf
path: doc/_build/latex/*.pdf
retention-days: 7

smoke-tests:
name: Build and Smoke tests
runs-on: ${{ matrix.os }}
Expand Down
7 changes: 0 additions & 7 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,3 @@ jobs:
name: documentation-html
path: doc/_build/html
retention-days: 7

- name: Upload PDF Documentation
uses: actions/upload-artifact@v4
with:
name: documentation-pdf
path: doc/_build/latex/*.pdf
retention-days: 7
5 changes: 1 addition & 4 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,4 @@ deps =
-e .[doc]
allowlist_externals = make
commands =
sphinx-build -M html "{toxinidir}/doc/source" "{toxinidir}/doc/_build" -j auto
sphinx-build -M latex "{toxinidir}/doc/source" "{toxinidir}/doc/_build" -j auto
cd "{toxinidir}/doc/_build/latex" && latexmk -r latexmkrc -pdf *.tex -interaction=nonstopmode || true
(test -f "{toxinidir}/doc/_build/latex/*.pdf" && echo pdf exists) || exit 1
sphinx-build -M html "{toxinidir}/doc/source" "{toxinidir}/doc/_build" -j auto

0 comments on commit d7e7d6a

Please sign in to comment.