Skip to content

Commit

Permalink
Merge branch 'main' into fix/missing-import-in-queries
Browse files Browse the repository at this point in the history
  • Loading branch information
clatapie authored Jul 31, 2023
2 parents cad22f8 + b05b13d commit 01a0ce1
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ jobs:
strategy:
fail-fast: false
matrix:
mapdl-version: ['v21.1.1', 'v21.2.1', 'v22.1.0', 'v22.2.0', 'v22.2-ubuntu', 'v23.1.0', 'v23.2.0']
mapdl-version: ['v21.1.1', 'v21.2.1', 'v22.1.0', 'v22.2.0', 'v22.2-ubuntu', 'v23.1.0', 'v23.2.0', 'v24.1.0']
extended_testing:
- ${{ github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || ( github.event_name == 'push' && contains(github.ref, 'refs/tags') ) }}
exclude:
Expand Down
36 changes: 35 additions & 1 deletion doc/source/getting_started/versioning.rst
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,45 @@ allows you to control a local instance of MAPDL. These versions of
MAPDL support specific versions of Windows and Linux.
For more information on supported platforms, see
`Ansys Platform Support <ansys_platform_support_>`_.

The CORBA interface is likely to be phased out from MAPDL at some
point. The gRPC interface is faster, more stable, and can run in
both local and remote connection configurations.

Deprecation of CORBA Interface in PyMAPDL
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Starting from version v0.67 of PyMAPDL library, the CORBA interface
will be deprecated and eventually removed.
This decision is driven by the CORBA library's lack of support
for Python versions above 3.8.

**Action Required:** If you currently rely on the CORBA interface,
we recommend planning for its replacement as you migrate to
PyMAPDL v0.67 or later versions. Specifying a different mode when
launching MAPDL should suffice. We understand that this change
may impact some users, and we apologize for any inconvenience it
may cause.

**Why is this happening?** As the Python ecosystem evolves,
maintaining compatibility with outdated libraries becomes
increasingly challenging. By removing the CORBA interface,
we can ensure PyMAPDL remains compatible with modern Python
environments, enabling us to provide better functionality and
support in the future.

**When will this happen?** The deprecation process will start
with version v0.66 and it will be completed with version v0.67.
While the exact timeline for the removal is yet to be determined,
it is essential to prepare for its eventual deprecation.

**Alternative Solutions:** For users requiring similar functionality,
we recommend exploring alternative interfaces available in PyMAPDL.

We greatly appreciate your support and understanding during this transition.
If you have any questions or concerns regarding this change, please
feel free to reach out to our support team in
`PyMAPDL discussions <pymapdl_discussions_>`_ or by email |pyansys_contact|.

Console interface
-----------------
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ doc = [
"pythreejs==2.4.2",
"pyvista[trame]==0.40.1",
"sphinx-autobuild==2021.3.14",
"sphinx-autodoc-typehints==1.23.0",
"sphinx-autodoc-typehints==1.24.0",
"sphinx-copybutton==0.5.2",
"sphinx-gallery==0.13.0",
"sphinx-notfound-page==0.8.3",
Expand Down
15 changes: 11 additions & 4 deletions src/ansys/mapdl/core/launcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -993,8 +993,9 @@ def launch_mapdl(
The ``'grpc'`` mode is available on ANSYS 2021R1 or newer and
provides the best performance and stability. The ``'corba'``
mode is available from v17.0 and newer and is given legacy
support. This mode requires the additional
``ansys_corba`` module. Finally, the ``'console'`` mode
support. However only Python up to 3.8 is supported.
This mode requires the additional ``ansys_corba`` module.
Finally, the ``'console'`` mode
is for legacy use only Linux only prior to v17.0. This console
mode is pending depreciation.
Visit :ref:`versions_and_interfaces` for more information.
Expand Down Expand Up @@ -1297,11 +1298,11 @@ def launch_mapdl(
>>> mapdl = launch_mapdl(start_instance=False, ip='192.168.1.30',
... port=50001)
Force the usage of the CORBA protocol.
Force the usage of the CORBA protocol (not recommended).
>>> mapdl = launch_mapdl(mode='corba')
Run MAPDL using the console mode (available only on Linux).
Run MAPDL using the console mode (not recommended, and available only on Linux).
>>> mapdl = launch_mapdl('/ansys_inc/v194/ansys/bin/ansys194',
... mode='console')
Expand Down Expand Up @@ -1617,6 +1618,12 @@ def check_mode(mode, version):
elif os.name == "posix":
raise VersionError("gRPC mode requires MAPDL 2021R1 or newer.")
elif mode == "corba":
warnings.warn(
"The CORBA interface is going to be deprecated with the version"
" v0.67 release. Please use the gRPC interface instead.\n"
"For more information visit: "
"https://mapdl.docs.pyansys.com/version/0.66/getting_started/versioning.html#corba-interface"
)
if version < 170:
raise VersionError("CORBA AAS mode requires MAPDL v17.0 or newer.")
if version >= 211:
Expand Down

0 comments on commit 01a0ce1

Please sign in to comment.