Allowing brackets and spaces in parameters name #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding parameter name check to mapdl.dim
Moving unit tests from mapdl to parameters.
Added context manager for full output (PARMS, _PARMS, PARMS_) Added parameter name check when using parameters.__setitem__
Codecov Report
@@ Coverage Diff @@
## main #1052 +/- ##
==========================================
+ Coverage 71.32% 71.48% +0.15%
==========================================
Files 43 43
Lines 6086 6127 +41
==========================================
+ Hits 4341 4380 +39
- Misses 1745 1747 +2 |
|
@akaszynski I'm merging without review. Anyway, please fill free to have a look. We can do a hot fix if needed. |
germa89
added a commit
that referenced
this pull request
Apr 20, 2022
* Fixing array indexing issue. * Improving unit tests * Adding % and improving unit tests * Fixing tests * Improving comments * Improving indexing detection during parameter name check. Adding parameter name check to mapdl.dim * Improving parameter retrieving * Adding unit tests. Moving unit tests from mapdl to parameters. * Added documentation Added context manager for full output (PARMS, _PARMS, PARMS_) Added parameter name check when using parameters.__setitem__ * Adding parameters.__setitem__ to tests. * fixing parameter name in context manager. * Fixing unit tests * Fixing codacity warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1050
== Final additions ==
After working on this, I also did some improvements:
parameters.__setitem__.PARMS,_PARMS,PARMS_). We should be also able to retrieve_PARMS_.