Removing scooby dependency
#1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1092 +/- ##
==========================================
+ Coverage 73.02% 73.17% +0.15%
==========================================
Files 43 43
Lines 6383 6413 +30
==========================================
+ Hits 4661 4693 +32
+ Misses 1722 1720 -2 |
akaszynski
approved these changes
May 3, 2022
There was a problem hiding this comment.
This is good work.
Next step is to use pyansys-tools-report when it's public to avoid duplication.
akaszynski
reviewed
May 3, 2022
akaszynski
reviewed
May 3, 2022
germa89
added a commit
that referenced
this pull request
May 4, 2022
* fixing forgotten pyvista import * Added base class for reporting. So scooby is not enforced. * Removing self * Fixing code coverage * Fixing unit tests. * Improving coverage * Update src/ansys/mapdl/core/misc.py Co-authored-by: Alex Kaszynski <[email protected]> (cherry picked from commit cc11149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of enforcing
scooby, I'm getting a basic template. I think this makes sense because of:mapdl_info, which is still used; and whengpuis equalTruewhich requiresPyvista, which installscooby. Since we do not want to depend onPyvista, I think this makes sense.Close #1086