Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injecting env vars in MAPDL process #1219

Merged
merged 9 commits into from
Jul 23, 2022
Merged

Injecting env vars in MAPDL process #1219

merged 9 commits into from
Jul 23, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 22, 2022

Using subprocess.Popen(..., env), we should be able to start the MAPDL process with specifics env variables.

Close #1218

@germa89 germa89 added this to the v0.63 milestone Jun 22, 2022
@germa89 germa89 self-assigned this Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1219 (1c797a3) into main (39402d2) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
+ Coverage   75.86%   75.90%   +0.04%     
==========================================
  Files          43       43              
  Lines        6765     6777      +12     
==========================================
+ Hits         5132     5144      +12     
  Misses       1633     1633              

@germa89
Copy link
Collaborator Author

germa89 commented Jun 22, 2022

I'm going to ignore the Code Static analysis because we control the shell part which is flagged. @akaszynski

@germa89 germa89 marked this pull request as ready for review June 22, 2022 12:26
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @germa89!

@akaszynski akaszynski enabled auto-merge (squash) July 23, 2022 00:02
@akaszynski akaszynski merged commit ddcbb76 into main Jul 23, 2022
@akaszynski akaszynski deleted the feat/inject-env-vars branch July 23, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Being able to inject var envs
2 participants