-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to open_gui
#1267
Merged
Merged
Improvements to open_gui
#1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1267 +/- ##
==========================================
+ Coverage 75.16% 75.80% +0.63%
==========================================
Files 43 43
Lines 6794 6761 -33
==========================================
+ Hits 5107 5125 +18
+ Misses 1687 1636 -51 |
@akaszynski please have a look. If you approve, I will merge without the codestatic check passing. |
akaszynski
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
germa89
added a commit
that referenced
this pull request
Jul 15, 2022
* Implement the option to run inplace. Using original jobname. * Making sure the start_parameter is updated and stored. * Added MAPDLdidnotstart exception class. * Using new error class. * Updated docstring. * removing error classes. * small fix. * Making sure there is no edge cases in args * Fixing coverage and adding unit tests to error classes. * Updating docstrings * fixing error class inits * fixing init load (cherry picked from commit a25ae7e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the name of the temporal database to the original db file name.
Added option to run
open_gui
from the working location. By default, this is not the case.Close #1266