Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to open_gui #1267

Merged
merged 13 commits into from
Jul 15, 2022
Merged

Improvements to open_gui #1267

merged 13 commits into from
Jul 15, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 15, 2022

Change the name of the temporal database to the original db file name.

Added option to run open_gui from the working location. By default, this is not the case.

Close #1266

@germa89 germa89 added this to the v0.62.2 milestone Jul 15, 2022
@germa89 germa89 self-assigned this Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1267 (7f5e824) into main (18d2bc0) will increase coverage by 0.63%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##             main    #1267      +/-   ##
==========================================
+ Coverage   75.16%   75.80%   +0.63%     
==========================================
  Files          43       43              
  Lines        6794     6761      -33     
==========================================
+ Hits         5107     5125      +18     
+ Misses       1687     1636      -51     

@germa89 germa89 requested a review from akaszynski July 15, 2022 15:15
@germa89
Copy link
Collaborator Author

germa89 commented Jul 15, 2022

@akaszynski please have a look. If you approve, I will merge without the codestatic check passing.

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akaszynski akaszynski merged commit a25ae7e into main Jul 15, 2022
@akaszynski akaszynski deleted the fix/open_gui branch July 15, 2022 16:39
germa89 added a commit that referenced this pull request Jul 15, 2022
* Implement the option to run inplace. Using original jobname.

* Making sure the start_parameter is updated and stored.

* Added MAPDLdidnotstart exception class.

* Using new error class.

* Updated docstring.

* removing error classes.

* small fix.

* Making sure there is no edge cases in args

* Fixing coverage and adding unit tests to error classes.

* Updating docstrings

* fixing error class inits

* fixing init load

(cherry picked from commit a25ae7e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in open_gui()
2 participants