Renaming remove_temp_files to remove_temp_dir_on_exit

[germa89]

Close #1387 by renaming remove_temp_files to remove_temp_dir_on_exit which I believe it is more accurate and self descriptive.

I have also implemented a warning.

[codecov]

Codecov Report

Merging #1466 (8949acd) into main (b67b2ce) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
+ Coverage   80.32%   80.42%   +0.09%     
==========================================
  Files          43       43              
  Lines        6780     6773       -7     
==========================================
+ Hits         5446     5447       +1     
+ Misses       1334     1326       -8     

[germa89]

The option stack_level in:

warnings.warn(
                "The option ``remove_temp_files`` is being deprecated and it will be removed by PyMAPDL version 0.66.0.\n"
                "Please use ``remove_temp_dir_on_exit`` instead.",
                DeprecationWarning,
                stacklevel=2,
            )

is useful to make the warning shows in the main process and also to:

This makes the warning refer to deprecation()’s caller, rather than to the source of deprecation() itself (since the latter would defeat the purpose of the warning message).

Reference: https://docs.python.org/3/library/warnings.html#warnings.warn

[germa89]

The option stack_level in:

warnings.warn(
                "The option ``remove_temp_files`` is being deprecated and it will be removed by PyMAPDL version 0.66.0.\n"
                "Please use ``remove_temp_dir_on_exit`` instead.",
                DeprecationWarning,
                stacklevel=2,
            )

is useful to make the warning shows in the main process and also to:

This makes the warning refer to deprecation()’s caller, rather than to the source of deprecation() itself (since the latter would defeat the purpose of the warning message).

Reference: https://docs.python.org/3/library/warnings.html#warnings.warn

Pinging @pyansys/pyansys-core FYI.

[germa89]

LGTM.