-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stopping license checker once it is connected #1491
Merged
germa89
merged 13 commits into
main
from
feat/stopping-license-checker-once-it-is-connected-
Sep 15, 2022
Merged
Stopping license checker once it is connected #1491
germa89
merged 13 commits into
main
from
feat/stopping-license-checker-once-it-is-connected-
Sep 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added thread stopper.
Codecov Report
@@ Coverage Diff @@
## main #1491 +/- ##
==========================================
+ Coverage 80.32% 81.59% +1.27%
==========================================
Files 43 43
Lines 6779 6737 -42
==========================================
+ Hits 5445 5497 +52
+ Misses 1334 1240 -94 |
germa89
commented
Sep 15, 2022
germa89
commented
Sep 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes.
…ttps://github.com/pyansys/pymapdl into feat/stopping-license-checker-once-it-is-connected-
germa89
deleted the
feat/stopping-license-checker-once-it-is-connected-
branch
September 15, 2022 15:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title.
I also refactored the license checker class so now all the functions are methods.