Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving ubuntu devcontainer #1752

Merged
merged 39 commits into from
Feb 23, 2023
Merged

Improving ubuntu devcontainer #1752

merged 39 commits into from
Feb 23, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 3, 2023

Smoothing the usage of our docker image in codespace and as remote container.

@germa89 germa89 added the CI/CD Related with CICD, Github Actions, etc label Jan 3, 2023
@germa89 germa89 self-assigned this Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023 •
edited
Loading

Codecov Report

Merging #1752 (6f43879) into main (54258bb) will decrease coverage by 4.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1752      +/-   ##
==========================================
- Coverage   85.86%   80.91%   -4.95%     
==========================================
  Files          44       44              
  Lines        7844     7844              
==========================================
- Hits         6735     6347     -388     
- Misses       1109     1497     +388

akaszynski
akaszynski reviewed Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go, but check with Marc prior to merge.

@germa89
Copy link
Collaborator Author

germa89 commented Jan 26, 2023

Legal issues leave this PR a bit of without scope.

Basically, we can't provide users with docker images. Hence this whole approach for devops lacks of purpose, unless it is just to give some guidance, so the users can build their own docker images. But that is a different story.

However I think the approach still works internally (hence I'm going to keep the configuration files) but I will rework the documentation to explain a bit the process for users.

germa89 and others added 16 commits February 5, 2023 03:22
akaszynski
akaszynski approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go.

No public containers (yet), but internal containers are good to go.

@germa89
Copy link
Collaborator Author

germa89 commented Feb 23, 2023

LGTM

pyansys-ci-bot
pyansys-ci-bot approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so 😬

@germa89 germa89 enabled auto-merge (squash) February 23, 2023 07:16
@germa89 germa89 merged commit eda2e39 into main Feb 23, 2023
@germa89 germa89 deleted the feat/improving-ubuntu-devcontainer branch February 23, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@akaszynski akaszynski akaszynski approved these changes

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@germa89 @akaszynski @pyansys-ci-bot