-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an example of a GUI application with PySide6 #2095
Conversation
for more information, see https://pre-commit.ci
…pymapdl into fix/cpxmod-field-for-eigs
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #2095 +/- ##
==========================================
+ Coverage 86.43% 86.48% +0.04%
==========================================
Files 45 45
Lines 7971 7981 +10
==========================================
+ Hits 6890 6902 +12
+ Misses 1081 1079 -2 |
Maybe I should add some screenshots of the app |
Good idea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice application ! I reviewed the related documentation but not the code yet.
A second review will follow.
Nice work @Gryfenfer97 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice application ! I reviewed the related documentation but not the code yet.
A second review will follow.
Nice work @Gryfenfer97 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I locally run the codes and it looks great. My only technical comment is about dependencies.
Congrats @Gryfenfer97!
doc/source/examples/extended_examples/gui/final_app_postprocessing.png
Outdated
Show resolved
Hide resolved
Fixing vocabulary issues Fixing srt syntax issues Co-authored-by: Camille <[email protected]>
doc/source/examples/extended_examples/gui/final_app_preprocessing.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like you to comment more the GUI file. Since we are not explaining much what each block of code is doing, I think it is good to write some comment in the Python file.
Co-authored-by: German <[email protected]>
Pinging @PipKat for documentation review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc review per German's request.
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
I saw your comment about adding graphics of the app. Just remember keeping graphics up to date is a maintenance issue! I'd advise adding only graphics that seem necessary! |
Good advice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Example of a GUI application made with Pyside6