Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an example of a GUI application with PySide6 #2095

Merged
merged 33 commits into from
Jun 16, 2023
Merged

Create an example of a GUI application with PySide6 #2095

merged 33 commits into from
Jun 16, 2023

Conversation

Gryfenfer97
Copy link
Contributor

@Gryfenfer97 Gryfenfer97 commented Jun 1, 2023

Example of a GUI application made with Pyside6

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #2095 (3ad8f6a) into main (09d55a4) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2095      +/-   ##
==========================================
+ Coverage   86.43%   86.48%   +0.04%     
==========================================
  Files          45       45              
  Lines        7971     7981      +10     
==========================================
+ Hits         6890     6902      +12     
+ Misses       1081     1079       -2     

@Gryfenfer97 Gryfenfer97 marked this pull request as ready for review June 2, 2023 11:35
@Gryfenfer97 Gryfenfer97 requested a review from germa89 June 2, 2023 11:35
@Gryfenfer97
Copy link
Contributor Author

Maybe I should add some screenshots of the app

@germa89
Copy link
Collaborator

germa89 commented Jun 2, 2023

Maybe I should add some screenshots of the app

Good idea!

@germa89 germa89 requested a review from clatapie June 2, 2023 13:08
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice application ! I reviewed the related documentation but not the code yet.
A second review will follow.
Nice work @Gryfenfer97 👍

doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice application ! I reviewed the related documentation but not the code yet.
A second review will follow.
Nice work @Gryfenfer97 👍

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I locally run the codes and it looks great. My only technical comment is about dependencies.
Congrats @Gryfenfer97!

doc/source/examples/extended_examples/gui/gui.py Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/gui_app.py Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/gui_app.py Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/gui_app.py Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/gui_app.py Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/gui_app.py Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/gui_app.py Outdated Show resolved Hide resolved
Fixing vocabulary issues
Fixing srt syntax issues

Co-authored-by: Camille <[email protected]>
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/index.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like you to comment more the GUI file. Since we are not explaining much what each block of code is doing, I think it is good to write some comment in the Python file.

doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
doc/source/examples/extended_examples/gui/executable.rst Outdated Show resolved Hide resolved
@germa89 germa89 requested a review from PipKat June 12, 2023 15:33
@germa89
Copy link
Collaborator

germa89 commented Jun 12, 2023

Pinging @PipKat for documentation review.

Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc review per German's request.

@Gryfenfer97
Copy link
Contributor Author

@germa89

@PipKat
Copy link
Member

PipKat commented Jun 14, 2023

I saw your comment about adding graphics of the app. Just remember keeping graphics up to date is a maintenance issue! I'd advise adding only graphics that seem necessary!

@germa89
Copy link
Collaborator

germa89 commented Jun 16, 2023

I saw your comment about adding graphics of the app. Just remember keeping graphics up to date is a maintenance issue! I'd advise adding only graphics that seem necessary!

Good advice!

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@germa89 germa89 merged commit a24127b into main Jun 16, 2023
@germa89 germa89 deleted the example/gui branch June 16, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants