Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating example directory when needed #2111

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Creating example directory when needed #2111

merged 4 commits into from
Jun 12, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 12, 2023

Close #2086.

@germa89 germa89 changed the title Creating example directory when need Creating example directory when needed Jun 12, 2023
@germa89 germa89 requested review from clatapie and raph-luc June 12, 2023 10:13
@germa89 germa89 self-assigned this Jun 12, 2023
@germa89 germa89 enabled auto-merge (squash) June 12, 2023 10:14
raph-luc
raph-luc approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@raph-luc raph-luc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor writing suggestion, and interesting way to do it using a wrapper, looks good to me

tests/test_examples.py Outdated Show resolved Hide resolved
clatapie
clatapie approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

@codecov
Copy link

codecov bot commented Jun 12, 2023 •
edited
Loading

Codecov Report

Merging #2111 (709c71d) into main (09d55a4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2111      +/-   ##
==========================================
+ Coverage   86.43%   86.45%   +0.01%     
==========================================
  Files          45       45              
  Lines        7971     7981      +10     
==========================================
+ Hits         6890     6900      +10     
  Misses       1081     1081

@germa89 germa89 merged commit c1eb1e5 into main Jun 12, 2023
@germa89 germa89 deleted the feat/create-folder-when-actually-needed branch June 12, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raph-luc raph-luc raph-luc approved these changes

@clatapie clatapie clatapie approved these changes

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating directories only if used.
3 participants
@germa89 @clatapie @raph-luc