Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detaching examples #2192

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Detaching examples #2192

merged 2 commits into from
Jul 25, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 19, 2023

Close #2191

Testing:

I will look into adding some unit tests, but it seems difficult to achieve.

In [2]: import sys

In [3]: "ansys.mapdl.core" in sys.modules
Out[3]: False

In [4]: "requests" in sys.modules
Out[4]: False

In [5]: "ansys.mapdl.core.examples" in sys.modules
Out[5]: False

In [6]: from ansys.mapdl import core as pymapdl

In [7]: "ansys.mapdl.core" in sys.modules
Out[7]: True

In [8]: "ansys.mapdl.core.examples" in sys.modules
Out[8]: False

In [9]: "requests" in sys.modules
Out[9]: False

In [10]: from ansys.mapdl.core.examples import vmfiles

In [11]: "ansys.mapdl.core.examples" in sys.modules
Out[11]: True

In [12]: "requests" in sys.modules
Out[12]: True

@germa89 germa89 requested review from Gryfenfer97 and clatapie July 19, 2023 12:41
@germa89 germa89 self-assigned this Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2192 (866c7ba) into main (997e288) will increase coverage by 6.46%.
The diff coverage is 96.76%.

@@            Coverage Diff             @@
##             main    #2192      +/-   ##
==========================================
+ Coverage   80.82%   87.29%   +6.46%     
==========================================
  Files          44       45       +1     
  Lines        7489     8098     +609     
==========================================
+ Hits         6053     7069    +1016     
+ Misses       1436     1029     -407     

@germa89
Copy link
Collaborator Author

germa89 commented Jul 24, 2023

@clatapie

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit a3e9be6 into main Jul 25, 2023
@germa89 germa89 deleted the feat/detaching-examples-libraries branch July 25, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detach examples submodule
2 participants