Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mapdl.solution() to enter in solution processor #2293

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 1, 2023

This allows us to do:

# define model
mapdl.solution()
mapdl.solve()

Which is more natural than using mapdl.slashsolution

@germa89 germa89 requested review from koubaa and mikerife September 1, 2023 10:26
@germa89 germa89 self-assigned this Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #2293 (a11cbf6) into main (e3885fb) will increase coverage by 1.20%.
Report is 117 commits behind head on main.
The diff coverage is 91.42%.

@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
+ Coverage   86.39%   87.59%   +1.20%     
==========================================
  Files          45       45              
  Lines        7977     8435     +458     
==========================================
+ Hits         6892     7389     +497     
+ Misses       1085     1046      -39     

@germa89 germa89 requested a review from clatapie September 5, 2023 08:12
@germa89 germa89 enabled auto-merge (squash) September 5, 2023 08:12
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit 8358515 into main Sep 5, 2023
@germa89 germa89 deleted the feat/mapdl.solution()-now-opens-the-solution-procesor branch September 5, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants