Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing some plot stuff and small gallery improvements #2349

Merged
merged 57 commits into from
Oct 2, 2023
Merged

Fixing some plot stuff and small gallery improvements #2349

merged 57 commits into from
Oct 2, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 19, 2023 •
edited
Loading

As the title.

  • Changing the default thumbnail.
  • Fixing some backgrounds in some examples.
  • Fixing a bug in the resizing of colors in color_area.
  • Reorganizing the plot tests... move them all to test_plotting or test_post
  • Using a bit more the pytest-pyvista extension to get more plots.
  • Fixing not passing color argument to plots.

Close #2351

@germa89 germa89 self-assigned this Sep 19, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Sep 20, 2023

I wish all people were so pro-active as this bot... @RobPasMue I didnt ask for this review xDD

@germa89
Copy link
Collaborator Author

germa89 commented Sep 20, 2023

@ansys-reviewer-bot stop review

@ansys-reviewer-bot
Copy link
Contributor

Okay, I will not perform any more reviews on your PR.

@RobPasMue
Copy link
Member

I wish all people were so pro-active as this bot... @RobPasMue I didnt ask for this review xDD

As I mentioned - the bot triggers the review automatically whenever you open a PR or do a commit to an existing PR

@germa89
Copy link
Collaborator Author

germa89 commented Sep 20, 2023

I wish all people were so pro-active as this bot... @RobPasMue I didnt ask for this review xDD

As I mentioned - the bot triggers the review automatically whenever you open a PR or do a commit to an existing PR

Ohh jesus....

@RobPasMue
Copy link
Member

Yep let me try to change that behavior as soon as I can 😄

@germa89 germa89 mentioned this pull request Sep 20, 2023
Closed
RobPasMue
RobPasMue approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usage of the cache. I hope it helps for your purpose. I see you fixed the cache directory issue

@germa89 germa89 marked this pull request as draft September 26, 2023 07:41
@germa89
Copy link
Collaborator Author

germa89 commented Sep 26, 2023

Nice usage of the cache. I hope it helps for your purpose. I see you fixed the cache directory issue

Thank you a lot for the feedback @RobPasMue !!

@germa89
Copy link
Collaborator Author

germa89 commented Sep 26, 2023

We need first merge #2359

@germa89 germa89 marked this pull request as ready for review October 2, 2023 09:09
@germa89 germa89 enabled auto-merge (squash) October 2, 2023 15:58
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Hello! 👋

Your PR is changing the image cache. So I am attaching the new image cache
in a new commit.

This commit does not re-run the CICD workflows (since no changes are made in the codebase) therefore
you will see the actions showing in their status Expected — Waiting for status to be reported. Do not worry.
You commit workflow is still running here 😄

You might want to rerun the test to make sure that everything is passing. You can retrigger the CICD sending an empty commit git commit -m "Empty comment to trigger CICD" --allow-empty.

You will see this message everytime your commit changes the image cache but you are not attaching the updated cache. 🤓

@germa89 germa89 merged commit c077163 into main Oct 2, 2023
20 checks passed
@germa89 germa89 deleted the fix/several-plot-fix branch October 2, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansys-reviewer-bot ansys-reviewer-bot[bot] ansys-reviewer-bot[bot] left review comments

@RobPasMue RobPasMue RobPasMue approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed scheduled build
2 participants
@germa89 @RobPasMue