Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate database testing in local. It should be skipped by pytest db fixture. #2393

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Activate database testing in local. It should be skipped by pytest db fixture. #2393

merged 2 commits into from
Oct 6, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 6, 2023 •
edited
Loading

As the title.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Merging #2393 (750cc60) into main (c077163) will increase coverage by 0.30%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2393      +/-   ##
==========================================
+ Coverage   87.92%   88.22%   +0.30%     
==========================================
  Files          44       44              
  Lines        8453     8453              
==========================================
+ Hits         7432     7458      +26     
+ Misses       1021      995      -26

@germa89 germa89 requested a review from clatapie October 6, 2023 16:12
@germa89 germa89 self-assigned this Oct 6, 2023
@germa89 germa89 enabled auto-merge (squash) October 6, 2023 16:13
@germa89
Copy link
Collaborator Author

germa89 commented Oct 6, 2023

LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

@germa89 germa89 merged commit 45fb148 into main Oct 6, 2023
24 checks passed
@germa89 germa89 deleted the ci/check-database-module-generally branch October 6, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germa89 @pyansys-ci-bot