-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PyMAPDL logo #2647
Adding PyMAPDL logo #2647
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2647 +/- ##
==========================================
+ Coverage 81.07% 82.27% +1.20%
==========================================
Files 47 47
Lines 9340 9344 +4
==========================================
+ Hits 7572 7688 +116
+ Misses 1768 1656 -112 |
only one comment, It will be better to keep the images inside the _static folder of document source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
I dont think we set that in the README in the github site... Howeverrr... check this https://mapdl.docs.pyansys.com/version/dev/index.html in both themes |
As the title.
Not the best logo though...
Regarding light/dark themes switchers: https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/light-dark.html