Protect execution from specific exceptions #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2677 +/- ##
==========================================
- Coverage 84.98% 82.31% -2.68%
==========================================
Files 47 47
Lines 9308 9322 +14
==========================================
- Hits 7910 7673 -237
- Misses 1398 1649 +251 |
germa89
requested review from
clatapie,
a team and
pyansys-ci-bot
and removed request for
a team
|
I think this PR has value... so I'm keeping it.. but I might think something different for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a decorator which will protect execution from specific exceptions.
I think it is cleaner way to avoid exceptions.
The idea was to fix #2676 by wrapping exit with
protect_from.. But I feel it might provoke an early exit.I could just wrap logging.info, logging.debug, etc... since we are calling it from our custom logger class. But adding many try and errors might slow down the code.