Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: converting chained APDL commands to PyMAPDL context manager #3154

Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 5, 2024

As the title.

Close #3153

@germa89 germa89 requested a review from a team as a code owner June 5, 2024 10:51
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 requested a review from mikerife June 5, 2024 10:51
@germa89 germa89 self-assigned this Jun 5, 2024
@germa89 germa89 enabled auto-merge (squash) June 5, 2024 10:52
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.17%. Comparing base (3dcb798) to head (dc68be3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
- Coverage   86.61%   84.17%   -2.45%     
==========================================
  Files          52       52              
  Lines        9528     9550      +22     
==========================================
- Hits         8253     8039     -214     
- Misses       1275     1511     +236     

Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit c61036a into main Jun 5, 2024
36 checks passed
@germa89 germa89 deleted the feat/converting-chained-comands-to-PyMAPDL-context-manager branch June 5, 2024 12:59
@clatapie clatapie changed the title Converting chained APDL commands to PyMAPDL context manager. feat: converting chained APDL commands to PyMAPDL context manager. Jun 18, 2024
@clatapie clatapie changed the title feat: converting chained APDL commands to PyMAPDL context manager. feat: converting chained APDL commands to PyMAPDL context manager Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use chain_commands in convert_script
2 participants