-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: removing reredirect sphinx extension #3224
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3224 +/- ##
==========================================
- Coverage 82.67% 82.62% -0.05%
==========================================
Files 53 53
Lines 9625 9625
==========================================
- Hits 7957 7953 -4
- Misses 1668 1672 +4 |
I just realised that this documentation was wrongly set. It was redirecting the krylov user guide to a broken link. So the extension works, but now it is not needed. |
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch check will never pass until a new branch and PR is set. Sooo... I'm merging anyway. |
Description
This is extension is no longer used (or at least I couldn't make it work properly ... almost ever).
Furthermore, with the change in the domain at the higher level, I dont think this extension is explicable for the current cases.
Issue linked
Close #3216
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)