Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: removing reredirect sphinx extension #3224

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 27, 2024

Description

This is extension is no longer used (or at least I couldn't make it work properly ... almost ever).

Furthermore, with the change in the domain at the higher level, I dont think this extension is explicable for the current cases.

Issue linked

Close #3216

Checklist

@germa89 germa89 requested a review from a team as a code owner June 27, 2024 13:00
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jun 27, 2024
@germa89 germa89 enabled auto-merge (squash) June 27, 2024 13:01
@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (587a0cb) to head (ed27293).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3224      +/-   ##
==========================================
- Coverage   82.67%   82.62%   -0.05%     
==========================================
  Files          53       53              
  Lines        9625     9625              
==========================================
- Hits         7957     7953       -4     
- Misses       1668     1672       +4     

@github-actions github-actions bot added the CI/CD Related with CICD, Github Actions, etc label Jul 8, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Jul 8, 2024

I just realised that this documentation was wrongly set. It was redirecting the krylov user guide to a broken link.

So the extension works, but now it is not needed.

@germa89
Copy link
Collaborator Author

germa89 commented Jul 8, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
Copy link
Collaborator Author

germa89 commented Jul 8, 2024

The branch check will never pass until a new branch and PR is set. Sooo... I'm merging anyway.

@germa89 germa89 merged commit e91a3dd into main Jul 8, 2024
64 of 65 checks passed
@germa89 germa89 deleted the build--remove-reredirect-pages-sphinx-extension branch July 8, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc dependencies documentation Documentation related (improving, adding, etc) maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Needs to check if sphinx-redirect extension is working
2 participants