-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: documenting new naming conventions for commits, branches and PRs. #3228
docs: documenting new naming conventions for commits, branches and PRs. #3228
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
…hes-and-PRs' of https://github.com/ansys/pymapdl into docs/document-new-naming-conventions-for-commits,-branches-and-PRs
Wiz Scan Summary
|
NOT finished. I need to fix the labels. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3228 +/- ##
==========================================
- Coverage 82.64% 80.21% -2.44%
==========================================
Files 53 53
Lines 9625 9625
==========================================
- Hits 7955 7721 -234
- Misses 1670 1904 +234 |
…mits,-branches-and-PRs
Ok. Now it is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor edits--mostly to get rid of "etc."--as we want to avoid Latin phrases.
Co-authored-by: Kathy Pippert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…mits,-branches-and-PRs
many people approved it. Hence @pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to disable P.D.- @pyansys-ci-bot token has been replaced by a @jorgepiloto's one. Hence for this PR to be merged I had to disable the above requirement, since the workflow now is triggered with @jorgepiloto's credentials which is not a codeowner. |
Why not add him to the team temporarily? |
Codeowners require to edit the |
No, you do not need to change the file - you just need to add @jorgepiloto to the @ansys/pymapdl-maintainers team. Line 8 in a0028e6
|
Description
As the title. I want to have everything clearly stated in the PyMAPDL development section.
Issue linked
Close #3218
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)