-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Raising ValueError
when using ips within pool library
#3240
Merged
germa89
merged 23 commits into
main
from
fix/raising-valueerror-when-using-ips-within-pool-library
Jul 10, 2024
Merged
fix: Raising ValueError
when using ips within pool library
#3240
germa89
merged 23 commits into
main
from
fix/raising-valueerror-when-using-ips-within-pool-library
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…eerror-when-using-ips-within-pool-library
germa89
requested review from
clatapie and
pyansys-ci-bot
and removed request for
a team
July 3, 2024 09:21
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
documentation
Documentation related (improving, adding, etc)
bug
Issue, problem or error in PyMAPDL
labels
Jul 3, 2024
PipKat
reviewed
Jul 3, 2024
Co-authored-by: Kathy Pippert <[email protected]>
…ry' of https://github.com/ansys/pymapdl into fix/raising-valueerror-when-using-ips-within-pool-library
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3240 +/- ##
==========================================
+ Coverage 86.61% 86.69% +0.08%
==========================================
Files 53 53
Lines 9630 9629 -1
==========================================
+ Hits 8341 8348 +7
+ Misses 1289 1281 -8 |
germa89
changed the title
Fix: Raising
fix: Raising Jul 8, 2024
ValueError
when using ips within pool libraryValueError
when using ips within pool library
clatapie
approved these changes
Jul 9, 2024
Gryfenfer97
approved these changes
Jul 9, 2024
…-within-pool-library
germa89
deleted the
fix/raising-valueerror-when-using-ips-within-pool-library
branch
July 10, 2024 13:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title. Latest changes in
MapdlPool
always passes the IP argument, so it is better to not raise this specific error when usingpool
.Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)