Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raising ValueError when using ips within pool library #3240

Merged

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 3, 2024

Description

As the title. Latest changes in MapdlPool always passes the IP argument, so it is better to not raise this specific error when using pool.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

@germa89 germa89 self-assigned this Jul 3, 2024
@germa89 germa89 requested a review from a team as a code owner July 3, 2024 09:21
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 3, 2024 09:21
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) bug Issue, problem or error in PyMAPDL labels Jul 3, 2024
src/ansys/mapdl/core/misc.py Outdated Show resolved Hide resolved
@germa89 germa89 requested a review from PipKat July 8, 2024 10:13
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.69%. Comparing base (9047d71) to head (476c336).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3240      +/-   ##
==========================================
+ Coverage   86.61%   86.69%   +0.08%     
==========================================
  Files          53       53              
  Lines        9630     9629       -1     
==========================================
+ Hits         8341     8348       +7     
+ Misses       1289     1281       -8     

@germa89 germa89 changed the title Fix: Raising ValueError when using ips within pool library fix: Raising ValueError when using ips within pool library Jul 8, 2024
@germa89 germa89 enabled auto-merge (squash) July 9, 2024 16:00
@germa89 germa89 merged commit 6090584 into main Jul 10, 2024
53 of 61 checks passed
@germa89 germa89 deleted the fix/raising-valueerror-when-using-ips-within-pool-library branch July 10, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants