-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: not deleting temporary file when remove_temp_dir_on_exit
=True
#3247
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
remove_temp_dir_on_exit
=True
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3247 +/- ##
==========================================
+ Coverage 82.67% 86.65% +3.98%
==========================================
Files 53 53
Lines 9625 9625
==========================================
+ Hits 7957 8341 +384
+ Misses 1668 1284 -384 |
Coverage issue related to #3250 |
Pinging @clatapie for a quick review |
b9fedda
to
3dd2f4b
Compare
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Fix not removing temporary directory when
remove_temp_dir_on_exit
== TrueIssue linked
Close #3246
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)