Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect env vars section #3252

Merged
merged 9 commits into from
Jul 9, 2024
Merged

fix: incorrect env vars section #3252

merged 9 commits into from
Jul 9, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 8, 2024

Description

As the title + cosmetic changes.

Issue linked

Close #3168

Checklist

germa89 added 2 commits July 8, 2024 18:38
@germa89
docs: fixing env vars.
5a9d2a3 
adding tabs for env vars
renaming tab keys.
format and cosmetic changes.
using ansys-tools-path for function reference.
@germa89
feat: adding ansys-tools-path breadcrumbs
65938b2
@germa89 germa89 requested a review from a team as a code owner July 8, 2024 16:40
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 8, 2024 16:40
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jul 8, 2024
@germa89 germa89 added the documentation Documentation related (improving, adding, etc) label Jul 8, 2024
@germa89 germa89 enabled auto-merge (squash) July 8, 2024 16:40
@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jul 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.61%. Comparing base (d4fe3a1) to head (e4e5708).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3252   +/-   ##
=======================================
  Coverage   86.61%   86.61%           
=======================================
  Files          53       53           
  Lines        9630     9630           
=======================================
  Hits         8341     8341           
  Misses       1289     1289

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Jul 9, 2024
@germa89 germa89 disabled auto-merge July 9, 2024 16:22
@germa89
Copy link
Collaborator Author

germa89 commented Jul 9, 2024

I'm merging anyways, because the problems here come from another place.

@germa89 germa89 merged commit 967c500 into main Jul 9, 2024
57 of 66 checks passed
@germa89 germa89 deleted the docs/fix-env-vars branch July 9, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

@pyansys-ci-bot pyansys-ci-bot Awaiting requested review from pyansys-ci-bot pyansys-ci-bot is a code owner automatically assigned from ansys/pymapdl-maintainers

Assignees

@germa89 germa89

Labels
bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify incorrect environment variables
2 participants
@germa89 @pyansys-ci-bot