-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement logger in convert_script #717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaszynski
changed the title
Feat/convert script logger
implement logger in convert_script
Nov 24, 2021
akaszynski
reviewed
Nov 24, 2021
akaszynski
reviewed
Nov 24, 2021
akaszynski
reviewed
Nov 24, 2021
akaszynski
reviewed
Nov 24, 2021
akaszynski
requested changes
Nov 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get the log capture working first.
Co-authored-by: Alex Kaszynski <[email protected]>
It should now work. |
akaszynski
reviewed
Nov 24, 2021
Co-authored-by: Alex Kaszynski <[email protected]>
akaszynski
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks for the fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request
Implement a logger on the converter script.
Implementation
The logger is quite simple. Basic stdout output. No format. Uses the standard
logging
module.The logging is made when we append the line to
FileTranslator.lines
through an overloadedappend
method in a customList
class.Use:
If the optional keyword
show_log
isTrue
inFileTranslator
, the resulting converted PyMAPDL is printed to the stdout.Example:
Closes #698