-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vm2 #728
Add vm2 #728
Conversation
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Kaszynski <[email protected]>
Co-authored-by: Alex Kaszynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial implementation of changes suggested in code review.
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
test Co-authored-by: Alex Kaszynski <[email protected]>
test Co-authored-by: Alex Kaszynski <[email protected]>
Looks like we're getting an error when evaluating: a = mapdl.post_processing.plot_nodal_eqv_stress()
|
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
We're now tracking this in #736 |
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
examples/06-verif-manual/vm-002-beam_stresses_and_deflections.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggestions. Most notable is using get_value
instead of get
.
Additionally, use nplot
or kplot
to visualize the engineering problem from MAPDL whenever possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made several changes to clean up the style a bit. Note how I added a sphinx cross reference to the function:
:py:meth:`Mapdl.get_value <ansys.mapdl.core.Mapdl.get_value>`.
You may want to also consider building the documentation locally. I think pycharm does a good job rendering the example rst, but there are some idiosyncrasies to our doc build that may not be rendered in sphinx.
Final suggestion:
Would it be possible to work out the hand-calculations for this? I'm fine with not having them, but if you've already worked out the hand calculations, you can just include it in the analytical section at the beginning of the example.
This PR adds VM2.