Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added type hint for the result property fixing #768 #769

Merged
merged 2 commits into from
Dec 9, 2021
Merged

added type hint for the result property fixing #768 #769

merged 2 commits into from
Dec 9, 2021

Conversation

jgd10
Copy link
Contributor

@jgd10 jgd10 commented Dec 8, 2021

Fixes #768

@jgd10 jgd10 requested review from akaszynski and germa89 December 8, 2021 15:11
germa89
germa89 previously requested changes Dec 8, 2021
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing to change.

ansys/mapdl/core/mapdl.py Outdated Show resolved Hide resolved
@jgd10
Copy link
Contributor Author

jgd10 commented Dec 9, 2021

@germa89 if you can approve this, it can be merged in

@akaszynski akaszynski dismissed germa89’s stale review December 9, 2021 14:49

Corrections made

akaszynski
akaszynski approved these changes Dec 9, 2021
View reviewed changes
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

@akaszynski akaszynski merged commit 4566ef4 into main Dec 9, 2021
@germa89 germa89 deleted the fix/issue_768 branch December 9, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

@germa89 germa89 germa89 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type hinting for mapdl.result is not present
3 participants
@jgd10 @akaszynski @germa89