Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detaching file location input from Mapdl.input #783

Merged
merged 19 commits into from
Dec 28, 2021

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 17, 2021

As the title.

This PR is related to #725 .

@germa89 germa89 self-assigned this Dec 17, 2021
tests/test_mapdl.py Outdated Show resolved Hide resolved
tests/test_mapdl.py Outdated Show resolved Hide resolved
@germa89 germa89 marked this pull request as draft December 17, 2021 18:50
@germa89 germa89 marked this pull request as ready for review December 20, 2021 13:49
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Next step is to apply this to various methods that could use this like cdread.

@akaszynski akaszynski merged commit 651bec5 into main Dec 28, 2021
@akaszynski akaszynski deleted the feat/file-location-in-input-related-commands branch December 28, 2021 13:49
@germa89 germa89 mentioned this pull request Apr 26, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants