Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ log_file keyword was not being used in _Mapdl #795

Merged
merged 2 commits into from
Dec 27, 2021
Merged

Fix/ log_file keyword was not being used in _Mapdl #795

merged 2 commits into from
Dec 27, 2021

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Dec 27, 2021

Close #794 by using log_file keyword argument to add a file handler.

@germa89 germa89 added the Bug label Dec 27, 2021
@germa89 germa89 self-assigned this Dec 27, 2021
akaszynski
akaszynski approved these changes Dec 27, 2021
View reviewed changes
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akaszynski akaszynski merged commit 6a2ba5a into main Dec 27, 2021
@akaszynski akaszynski deleted the fix/-missing-log-to-file-keyword- branch December 27, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log_file is not being used in main class
2 participants
@germa89 @akaszynski