Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing return #807

Merged
merged 4 commits into from
Jan 5, 2022
Merged

Added missing return #807

merged 4 commits into from
Jan 5, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 5, 2022

Close #806 by implementing missing return.

@germa89 germa89 added the Bug label Jan 5, 2022
@germa89 germa89 self-assigned this Jan 5, 2022
@akaszynski akaszynski closed this Jan 5, 2022
@akaszynski
Copy link
Collaborator

Abandoning, see notes in #806.

@akaszynski akaszynski deleted the fix/missing-return branch January 5, 2022 16:50
@germa89 germa89 restored the fix/missing-return branch January 5, 2022 17:05
@germa89 germa89 reopened this Jan 5, 2022
akaszynski
akaszynski approved these changes Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akaszynski akaszynski merged commit 4322126 into main Jan 5, 2022
@akaszynski akaszynski deleted the fix/missing-return branch January 5, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

Assignees

@germa89 germa89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing return in Mapdl class
2 participants
@germa89 @akaszynski