Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release doc build #812

Merged
merged 4 commits into from
Jan 7, 2022
Merged

fix release doc build #812

merged 4 commits into from
Jan 7, 2022

Conversation

akaszynski
Copy link
Collaborator

@akaszynski akaszynski commented Jan 7, 2022

Release documentation build for v0.60.4 broken. This PR should fixs it by moving the PDF build step after the initial html build step.

Additionally, this adds a manual upload step to overwrite broken release docs. Usage is make -C doc html deploy

akaszynski and others added 3 commits January 6, 2022 18:17
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I just added a small confirmation message in the Makefile (for the future users/devs).

So I guess we are moving the docs to its own repo...

Using tabs instead of spaces.
@akaszynski
Copy link
Collaborator Author

So I guess we are moving the docs to its own repo...

Correct, so now when you clone this repo you don't pull the docs as well, and pull will run faster as well because we no longer sync documentation.

I just added a small confirmation message in the Makefile (for the future users/devs).

Strongly agree with that. Thanks!

@akaszynski akaszynski merged commit 9cf157e into main Jan 7, 2022
@akaszynski akaszynski deleted the docs/fix_release_build branch January 7, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants