-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/example00 block code #825
Conversation
Can we add back in the commented code, but make it a markdown block? That way we can include it in the documentation. |
Went for adding back in the code but disabling executing with a simple flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
My main issue is that the code is not complete. It is missing a function which replicate the whole code (the one we execute) for different ratios (not sure which ratio means). Hence someone might try to run the example and see the code is not complete. I'm happy to add it back, but shouldn't we add the missing function? |
Absolutely. Sorry I missed that. It's a reminder why we run our documentation for each CI run. |
I will add it then. |
Updated analytical solution to match real geometry. Good match in the plot comparison.
Co-authored-by: Alex Kaszynski <[email protected]>
Close #821 by removing the double commented text.
I decided to remove it because since it is a dynamic example, it takes time from our building process, and it does not add anything from the 2D case:
https://mapdldocs.pyansys.com/examples/00-mapdl-examples/2d_plate_with_a_hole.html#ref-plane-stress-concentration