Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/example00 block code #825

Merged
merged 9 commits into from
Jan 17, 2022
Merged

Fix/example00 block code #825

merged 9 commits into from
Jan 17, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jan 11, 2022

Close #821 by removing the double commented text.

I decided to remove it because since it is a dynamic example, it takes time from our building process, and it does not add anything from the 2D case:

https://mapdldocs.pyansys.com/examples/00-mapdl-examples/2d_plate_with_a_hole.html#ref-plane-stress-concentration

@germa89 germa89 self-assigned this Jan 11, 2022
@akaszynski
Copy link
Collaborator

Can we add back in the commented code, but make it a markdown block? That way we can include it in the documentation.

@akaszynski
Copy link
Collaborator

Can we add back in the commented code, but make it a markdown block? That way we can include it in the documentation.

Went for adding back in the code but disabling executing with a simple flag.

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@germa89
Copy link
Collaborator Author

germa89 commented Jan 13, 2022

My main issue is that the code is not complete. It is missing a function which replicate the whole code (the one we execute) for different ratios (not sure which ratio means).

Hence someone might try to run the example and see the code is not complete.

I'm happy to add it back, but shouldn't we add the missing function?

@akaszynski
Copy link
Collaborator

I'm happy to add it back, but shouldn't we add the missing function?

Absolutely. Sorry I missed that. It's a reminder why we run our documentation for each CI run.

@germa89
Copy link
Collaborator Author

germa89 commented Jan 13, 2022

I will add it then.

@germa89 germa89 merged commit 5539a3e into main Jan 17, 2022
@germa89 germa89 deleted the fix/example00_block-code branch January 17, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong format in example 00
2 participants