clarify non supported commands #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaszynski
changed the title
akaszynski
reviewed
Jan 20, 2022
akaszynski
reviewed
Jan 20, 2022
akaszynski
reviewed
Jan 20, 2022
Comment on lines
+674
to
+677
| Some these commands do not make sense in a Python context. | ||
| For example the ``*ASK`` can be replaced with a Python ``input``, | ||
| ``*IF`` with a Python ``if`` statement, and instead of ``*CREATE`` and | ||
| ``*USE`` can simply call another Python function or module. |
There was a problem hiding this comment.
Provide a link to mapdl.input
Otherwise, great notes.
There was a problem hiding this comment.
But it is python input.
akaszynski
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Approved with minor suggestions.
Locally and as a PDF, sphinxemoji looks great. In fact, it matches what you'd see in popular repositories like kubernetes-client/python.
Codecov Report
@@ Coverage Diff @@
## main #843 +/- ##
=======================================
Coverage 57.58% 57.58%
=======================================
Files 172 172
Lines 10559 10559
=======================================
Hits 6080 6080
Misses 4479 4479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #837 by rewriting the section and adding table and emojis.
I do recognize that the emojis might look a bit .... not serious... I'm happy to delete them if needed. But I do think it helps to make the table more visual and less "exhausting to read".