Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong string argument in APDL logger #878

Merged
merged 6 commits into from
Feb 16, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 7, 2022

As the title.

I also added unit tests for the apdl logger.

@germa89 germa89 self-assigned this Feb 7, 2022
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #878 (4d08b19) into main (1913bf5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #878   +/-   ##
=======================================
  Coverage   59.22%   59.22%           
=======================================
  Files         172      172           
  Lines       10640    10640           
=======================================
  Hits         6302     6302           
  Misses       4338     4338           

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@akaszynski akaszynski merged commit 90421cb into main Feb 16, 2022
@akaszynski akaszynski deleted the fix/wrong-header-in-apdl_log branch February 16, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants