Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a MS Teams notification if nightlies (MAPDL or docs) fails #882

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 9, 2022

As the title.

I thought an email will be more useful, but

  • it is difficult to setup an outlook email because of the 2FA
  • We will need an email address for the project?

So, although I'm not big fan of MS Teams, let's give it a try.

@germa89 germa89 added Enhancement CI/CD Related with CICD, Github Actions, etc labels Feb 9, 2022
@germa89 germa89 self-assigned this Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #882 (28b2248) into main (c4664d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   59.22%   59.22%           
=======================================
  Files         172      172           
  Lines       10640    10640           
=======================================
  Hits         6302     6302           
  Misses       4338     4338           

@akaszynski
Copy link
Collaborator

Ha! This is actually really cool.

Please add this as a recommendation/best practice in our dev-guide.

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akaszynski akaszynski merged commit 8cd112f into main Feb 9, 2022
@akaszynski akaszynski deleted the feat/add-email-if-nightly-mapdl-fails branch February 9, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants