Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating returning parameters because of cpos #923

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Feb 22, 2022

Closes #922 by recreating returning parameters before exiting the general_plotter function.

@germa89 germa89 added the Bug label Feb 22, 2022
@germa89 germa89 self-assigned this Feb 22, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #923 (023e2bb) into main (efe93e3) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
+ Coverage   72.56%   72.60%   +0.04%     
==========================================
  Files          39       39              
  Lines        5697     5699       +2     
==========================================
+ Hits         4134     4138       +4     
+ Misses       1563     1561       -2     

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akaszynski akaszynski merged commit f6733c0 into main Feb 22, 2022
@akaszynski akaszynski deleted the fix/cpos-not-being-updated branch February 22, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpos is not updated after doing rotations
2 participants