Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load file in local mode #962

Merged
merged 9 commits into from
Mar 15, 2022
Merged

Fix load file in local mode #962

merged 9 commits into from
Mar 15, 2022

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Mar 11, 2022

I realised that in local mode this was failing.

Unfortunately all our test units are designed for non local. So this was not caught at the moment.

@germa89 germa89 added the BUG label Mar 11, 2022
@germa89 germa89 self-assigned this Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #962 (088ead9) into main (3e1e901) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
- Coverage   73.09%   73.08%   -0.01%     
==========================================
  Files          39       39              
  Lines        5720     5719       -1     
==========================================
- Hits         4181     4180       -1     
  Misses       1539     1539              

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

tests/test_math.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@akaszynski akaszynski enabled auto-merge (squash) March 14, 2022 16:15
@akaszynski akaszynski merged commit df11202 into main Mar 15, 2022
@akaszynski akaszynski deleted the fix/_load_file-in-local-mode branch March 15, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants